Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FE-187 remove copy project pipeline and tests #332

Merged
merged 43 commits into from
Apr 8, 2024
Merged

FE-187 remove copy project pipeline and tests #332

merged 43 commits into from
Apr 8, 2024

Conversation

bahill
Copy link
Contributor

@bahill bahill commented Mar 25, 2024 •
edited by jira bot
Loading

Why

FE-187

This PR

Removes the copy_project pipeline, solids, and related tests. These were all unused and may have been causing lag during e2e testing.

Checklist

  • Documentation has been updated as needed.

@github-actions github-actions bot force-pushed the FE-187-remove-copy_project-pipeline-and-tests branch from ef3675f to d863b1b Compare March 25, 2024 19:35
@github-actions github-actions bot force-pushed the FE-187-remove-copy_project-pipeline-and-tests branch from d863b1b to 34b1f9c Compare March 25, 2024 19:41
@codecov Codecov
Copy link

codecov bot commented Mar 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.56%. Comparing base (ed8a144) to head (edc8291).
Report is 13 commits behind head on main.

❗ Current head edc8291 differs from pull request most recent head 67b8797. Consider uploading reports for the commit 67b8797 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #332   +/-   ##
=======================================
  Coverage   95.56%   95.56%           
=======================================
  Files           4        4           
  Lines         158      158           
  Branches        5        5           
=======================================
  Hits          151      151           
  Misses          7        7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

bahill and others added 17 commits March 25, 2024 16:04
@bahill
removing unused copy_project related config
6cd5b28
@bahill
Merge remote-tracking branch 'origin/FE-187-remove-copy_project-pipel…
325773a 
…ine-and-tests' into FE-187-remove-copy_project-pipeline-and-tests
@bahill
Merge 325773a into 4af7883
7716a63
Update requirements.txt
73421af
@bahill
removing unused reference. (clean up from previous commit)
7385f6b
@bahill
removing unused references (clean up from previous commit)
cda082e
@bahill
Adding concurrency limiter - IE if a new push for the PR comes throug…
08f4e51 
…h stop the previously running jobs, if any.
@bahill
Merge remote-tracking branch 'origin/FE-187-remove-copy_project-pipel…
347db28 
…ine-and-tests' into FE-187-remove-copy_project-pipeline-and-tests
@bahill
Merge 347db28 into 4af7883
7c9bd98
Update requirements.txt
889da0c
@bahill
linting
1772fa4
@bahill
Merge remote-tracking branch 'origin/FE-187-remove-copy_project-pipel…
2feac9f 
…ine-and-tests' into FE-187-remove-copy_project-pipeline-and-tests
@bahill
linting
2d0b777
@bahill
first attempt to add sleep to load_hca to see if the e2e issue is tim…
a6dd141 
…e sensitive.
@bahill
Merge a6dd141 into 4af7883
c854614
Update requirements.txt
2cbf749
@bahill
linting
d4bec13
@bahill
Copy link
Contributor Author

bahill commented Apr 8, 2024 •
edited by jira bot
Loading

The e2e tests are failing (see FE-203) because they are running against TDR dev and TDR dev is apparently unstable.
As ingest we are customers of TDR so should be running e2e against prod TDR, where we are having no issues with release ingests.
We will address the refactoring of the e2e tests to run against prod in a future ticket. FE-204
This PR + FE=181 block the pushing of a security update to the HCA prod repo FE-171 so we will ignore the e2e failures for now and run manual smoke tests for this batch of tickets.

@bahill bahill marked this pull request as ready for review April 8, 2024 15:01
aherbst-broad
aherbst-broad approved these changes Apr 8, 2024
View reviewed changes
.github/workflows/validate_pull_request_main.yaml
@@ -3,6 +3,9 @@ on:
pull_request:
branches:
- main
concurrency:
group: ${{ github.ref }}
cancel-in-progress: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, is the idea that multiple e2e tests in flight are putting too much load on dev TDR?

@bahill bahill merged commit 8881ec0 into main Apr 8, 2024
1 check passed
@bahill bahill deleted the FE-187-remove-copy_project-pipeline-and-tests branch April 8, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aherbst-broad aherbst-broad aherbst-broad approved these changes

@kilonzi kilonzi kilonzi approved these changes

@samanthahv samanthahv Awaiting requested review from samanthahv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bahill @kilonzi @aherbst-broad